Fix Choice rejecting set and frozenset choices - #198
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Choice dispatches on the type of `choices` via singledispatchmethod, but only registered abc.Sequence, dict and type. Sets fall through to the base implementation and raise NotImplementedError, even though as_template(set()) returns a Choice, so sets are a documented way to build one. This regressed in v2.2.0. Registered abc.Set for both convert_choices and format_choices, widened the choices annotations to match, and added regression tests for set and frozenset choices. Closes beetbox#192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192.
Choicedispatches on the type ofchoicesviasingledispatchmethodand only registersabc.Sequence,dictandtype, so aset/frozensetfalls through to the base implementation and raisesNotImplementedError— even thoughas_template(set())returns aChoice, so sets are a supported way to build one.Registered
abc.Setforconvert_choicesandformat_choices(and widened thechoicesannotations to match). The four new tests fail withNotImplementedErrorwithout the source change and pass with it; full suite 297 passed.