Skip to content

Include default value in Choice template repr #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include default value in Choice template repr #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion confuse/templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,12 @@ def convert(self, value: object, view: ConfigView) -> T:
)

def __repr__(self) -> str:
return f"Choice({self.choices!r})"
args = [repr(self.choices)]

if self.default is not REQUIRED:
args.append(repr(self.default))

return f"Choice({', '.join(args)})"


class OneOf(Template[T]):
Expand Down
6 changes: 6 additions & 0 deletions test/test_valid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,12 @@ def test_validate_bad_choice_in_dict(self):
with pytest.raises(confuse.ConfigValueError):
config["foo"].get(confuse.Choice({2: "two", 4: "four"}))

def test_repr_without_default(self):
assert repr(confuse.Choice([1, 2])) == "Choice([1, 2])"

def test_repr_includes_default(self):
assert repr(confuse.Choice([1, 2], 2)) == "Choice([1, 2], 2)"


class OneOfTest(unittest.TestCase):
def test_default_value(self):
Expand Down
Loading