feat(discovery): add optional catalogue charts field for configs#335
feat(discovery): add optional catalogue charts field for configs#335davidlougheed wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #335 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 82 82
Lines 2536 2564 +28
Branches 233 240 +7
=========================================
+ Hits 2536 2564 +28
🚀 New features to boost your workflow:
|
SanjeevLakhwani
left a comment
There was a problem hiding this comment.
I agree we need a concept catalogue cards. Some things I do want to consider before saying this would be our final solution.
-
We currently can attach discovery config to both a project and a dataset.
-
Having catalogue charts on projects can make sense as they can have multiple datasets. On the other hand, having them on datasets doesn't make sense. We already have overview sections on them. A single dataset can't be called a catalogue.
-
To propose a solution, the minimal change could be separating out the concept of catalogue to a new one which can have the ability to be attached to a node and a project.
-
In our current usage we refer to catalogue on a node basis and this is currently not addressing that.
-
For future, we can use the concept of a chart definition file which can be attached to all the levels: node, project, dataset, with increasing selectivity. We can use this to refer in our discovery config definitions.
-
This would also help us having charts that can be catalogue specifics such as things based on project and dataset metadata.
|
@SanjeevLakhwani we can't really resolve fields in charts if theyre in another file. I'm fine with something, but we could also put a 'scope' optional param here for catalog-only or project-only configs? |
|
Add scope for now. But I would like the chart concept to be moved into a central file and discovery config and catalogue config to refer to it. We already create duplications by attaching it at multiple places. |
for showing charts above the data catalogue for multi-dataset instances.