Repository navigation
Use the title in a location's file wherever the place is named - #6
Merged
Merged
Conversation
… F-8a) F-8a asks for each location page "with the title and description from its R-10 file". The title was read into the index and then never used: stage 3 built every place's name from its path, so the page, the chips on a photograph and the lists on the front page all said "Norway » Bergen" whatever the file said. The description reached the page; the title did not. An undescribed place keeps its hierarchy (R-6), now as the index's own default title rather than the last level alone, so that the index and the site agree about what a place is called. Stage 3 reads the title from the index. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…om-its-file # Conflicts: # CHANGELOG.md # cmd/exposer/index.go # cmd/exposer/index_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-8a asks for each location page "with the title and description from its R-10 file". The title was read into the index (
Location.Title) and never used: stage 3 built every place's name from its path, so the page, the chips on a photograph and the front-page lists all said "Norway » Bergen" whatever the file said.Now stage 3 uses
Location.Title. A place with no file, or no title in it, keeps its hierarchy (R-6): the index default changes from the last level ("Oslo") to the whole path ("Norway » Oslo"), so that the index and the site agree.Judgment call, please check: this reads F-8a literally. The fixture's files say
title: Bergen, so on the fixture site the Bergen page and chips now read "Bergen" rather than "Norway » Bergen". If the intent was always to show the hierarchy and let the title only override the page heading, the change is small: keep the path inplaceRefsandnamed, and useloc.Titleonly for the page title. No existing test pins the old heading.Tests: page title comes from the file; undescribed places are named by hierarchy in the index and on the page. Both fail on
main. Golden index unchanged.Each PR adds a line under
Unreleased/Fixedin CHANGELOG.md, so merging several will conflict there; keep every line.🤖 Generated with Claude Code