Conversation
|
@beren12 Hi, I came here from the CurseForge page, where people are talking about this error too. Does this pull request look correct to you? Edit: To clarify. The changes in this pull request got rid of the crash for me. But I dunno if the changes are in the correct spirit of that function. |
|
People at https://www.curseforge.com/wow/addons/enhanced-flight-map are also mentioning another Lua error, by the way:
|
|
By the way @beren12 I highly recommend getting these tools:
Bug catching becomes extremely easy with these tools. |
|
Thanks I'll check this when the servers come back up. Sorry I've been so busy, I thought I fixed all the bugs when you didn't import/cleared the saved setting. |
|
I had done a similar fix it just punts the error down farther. I'll look into it some more. |
|
@beren12 Hey, that's understandable. Thanks for updating this addon for TBC, it's awesome. :-) Question btw: What's the preloaded flight data from? Did someone update it for TBC? Because the official addon (unmaintained version) has a note saying that all flight data is outdated. |
|
That’s the old note from way back in original TBC and wrath. I did all the alliance points for classic and gave them to the Dev and redid every point for alliance and hoard for TBC so it’s accurate |
|
It was many hours of flying |
|
@beren12 WoW, thank you, I can imagine like 7 hours of flying. Amazing job! |
|
@Bananaman the fix is too simple and too straight not to be sure about anything :) |
|
@Dramacydal Yeah but I haven't read through the code literally at all, so I don't know that. 😂 @beren12 I've been playing with the proposed fix since June 3rd and everything in Enhanced Flight Map has been working. I don't notice any issues at all. Any chance of investigating this pull request soon? |
3 participants
No description provided.