Skip to content

Fix: Virtual callback is handled in serial.js already #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haslinghuis merged 3 commits into from
Dec 17, 2025
+8 −12
Merged

Fix: Virtual callback is handled in serial.js already #4743

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c42a66
Callback is handled in serial.js already
haslinghuis Dec 16, 2025
4b4ce38
Remove unused openCancelled
haslinghuis Dec 16, 2025
8b2520d
Remove unused callback from disconnect and add return values
haslinghuis Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/js/protocols/VirtualSerial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@ class VirtualSerial {
this.transmitting = false;
this.outputBuffer = [];
}
connect(port, options, callback) {
connect(port, options) {
if (!this.openCanceled) {
this.connected = true;
this.connectionId = VIRTUAL;
this.bitrate = 115200;
callback();
}
}
disconnect(callback) {
Expand Down