Mutate Event/Hook - #25275
Draft
Diddykonga wants to merge 1 commit into
Draft
Conversation
Mutate Event/Hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutate Event/Hook
Objective
Lifecycle Hooks/Events currently cover Immutable Components changing value and changing structurally for all Components, but often times we would like it if it also covered Mutable Components changing value.
So that Lifecycle Hooks/Events cover All Components changing value or structurally.
Solution
Prior PR/Approach: #16143
Arrived at the same solution, didnt actually look at the code.
This approach attempts to give
SystemParam::apply/queuethe responsibility of triggering/queuing Mutate Events via Change Tick scans of their mutably-accessed Components.Some things to note:
ParamSetwith two identical queries.Access, which can containUnboundedacessess's (ex.EntityMutExcept<...>). In these cases we are not given any definite knowledge as to what was accessed and what wasn't so we must scan every component, except the ones excluded if any.Impled for Query, Single, Populated, ResMut, FilteredResourcesMut.
Testing
Showcase