-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Added a zoom to cursor option to PanCamera #25285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mbremner
wants to merge
6
commits into
bevyengine:main
Choose a base branch
from
mbremner:pan_camera_zoom_target_cursor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−3
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
969407d
Added a ZoomTarget enum to the PanCamera struct, with two variants: C…
mbremner f6625d8
Fixed some format issues identified by the CI job check
mbremner 2890a59
Fixed some format issues identified by the CI job check
mbremner fbffd14
Fixed some format issues identified by the CI job check
mbremner ce3c290
Fixed some format issues identified by the CI job check
mbremner c525a3f
Merge branch 'bevyengine:main' into pan_camera_zoom_target_cursor
mbremner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this make the controller not work when there are multiple windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe that this system would get skipped if there was more than one window. I had thought that that was already the case though. Line 178 of the 'main' branch (190 of the new branch) would cause the system to return immediately if there was multiple cameras. I guess I was assuming that multiple windows would require multiple cameras. Is that not correct?
I think handling multiple cameras or windows would get more complicated than I am comfortable handling right now. I think that to do it justice, I would need to set up a system for the user (developer) to define relationships between cameras.
I could change the Single<&Window> to Query<...> thought, or change the Query<Camera...> to Single<...> if that would make things clearer and more consistent.