Allow fallback error handlers to queue commands - #25288
Conversation
|
I really want a feature like this, but this might have surprising performance implications. Can you please benchmark this? |
Yeah sure :) |
Hey sorry for taking time, I benchmarked this against Environment:
Results:
The first sequential sweep reported regressions for the 10- and 1,000-system cases. I immediately repeated those cases with main and the branch run back-to-back. The regressions did not reproduce: Criterion reported no change ( No benchmark was classified as a performance regression by Criterion. Commands used: cargo bench --locked -p benches --bench ecs -- run_empty_schedule --save-baseline main
cargo bench --locked -p benches --bench ecs -- run_empty_schedule --baseline main
cargo bench --locked -p benches --bench ecs -- empty_systems --save-baseline main
cargo bench --locked -p benches --bench ecs -- empty_systems --baseline main
cargo bench --locked -p benches --bench ecs -- param/combinator_system/8_piped_systems --save-baseline main
cargo bench --locked -p benches --bench ecs -- param/combinator_system/8_piped_systems --baseline main |
Objective
Fixes #24821.
Solution
CommandstoErrorHandlerand return it from the handler.set_error_handlerdoc example demonstrating how to sendAppExit.