Move EntityCursor out of bevy_feathers to bevy_picking - #25294
Conversation
…ndencies to match this change.
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
|
I feel like this should be part of bevy_window not bevy_picking. Controlling the appearance of the cursor is done through the window api. |
|
Oh, but this would be a circular dependency |
alice-i-cecile
added
C-Usability
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Needs a migration guide, then I'm happy to approve this :) Very much in favor!
alice-i-cecile
added
S-Waiting-on-Author
|
@alice-i-cecile migration guide is added! |
There was a problem hiding this comment.
Does this have to have a , features = [ “custom_cursor” ] or something now?
There was a problem hiding this comment.
Mhmm, I'm curious about this too. Blocking on an answer here.
There was a problem hiding this comment.
Good catch, fixed it in the latest commit.
kfc35
added
S-Ready-For-Final-Review
5 participants
Objective
This PR addresses #25250.
As noted by @viridia,
Solution
Again, as noted by @viridia, this should probably be moved to
bevy_pickingfor obvious reasons.So, I moved the file
cursor.rsinbevy_featherstobevy_pickingand updated anything that depended on it, which was mostly the components inbevy_feathers/src/controlsand the toml files inbevy_feathers,bevy_picking, andbevy_internal.Migration guide
Should this be included in the migration guide? I assume so.
Lastly, this is my first PR to Bevy, and I'm quite new, so any feedback on this PR, whether on the description, code, or anything else, would be helpful!