fix: remove fake APIs from README, add explain/getColumns to Driver#11
Merged
fix: remove fake APIs from README, add explain/getColumns to Driver#11
Conversation
- Remove nonexistent APIs from README: Users.ddl(), Posts.ensureColumn(), Posts.ensureIndex(), Users.copyColumn() - Document real APIs: db.ensureTable(), db.ensureView(), db.ensureConstraints(), db.copyColumn(), db.explain() - Make getColumns required on Driver interface (was optional) - Add explain() to Driver interface - each driver owns its EXPLAIN syntax - Remove dialect-switching fallback from database.ts #checkColumnExists 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users.ddl(),Posts.ensureColumn(),Posts.ensureIndex(),Users.copyColumn()db.ensureTable(),db.ensureView(),db.ensureConstraints(),db.copyColumn(),db.explain()getColumnsrequired on Driver interface (was optional with dialect-switching fallback in database.ts)explain()to Driver interface - each driver implements its own EXPLAIN syntax#checkColumnExists- drivers own dialect-specific behaviorTest plan
🤖 Generated with Claude Code