Simplification Changes

Controllers/CommandsController.cs

@@ -22,56 +22,48 @@ public CommandsController(ICommanderRepo repository, IMapper mapper)
             _repository = repository;
             _mapper = mapper;
         }
-       
+
         //GET api/commands
         [HttpGet]
-        public ActionResult <IEnumerable<CommandReadDto>> GetAllCommmands()
+        public ActionResult<IEnumerable<CommandReadDto>> GetAllCommmands()
         {
             var commandItems = _repository.GetAllCommands();
 
             return Ok(_mapper.Map<IEnumerable<CommandReadDto>>(commandItems));
         }
 
         //GET api/commands/{id}
-        [HttpGet("{id}", Name="GetCommandById")]
-        public ActionResult <CommandReadDto> GetCommandById(int id)
+        [HttpGet("{id}", Name = "GetCommandById")]
+        public ActionResult<CommandReadDto> GetCommandById(int id)
         {
             var commandItem = _repository.GetCommandById(id);
-            if(commandItem != null)
-            {
+            if (commandItem != null)
                 return Ok(_mapper.Map<CommandReadDto>(commandItem));
-            }
             return NotFound();
         }
 
         //POST api/commands
         [HttpPost]
-        public ActionResult <CommandReadDto> CreateCommand(CommandCreateDto commandCreateDto)
+        public ActionResult<CommandReadDto> CreateCommand(CommandCreateDto commandCreateDto)
         {
             var commandModel = _mapper.Map<Command>(commandCreateDto);
             _repository.CreateCommand(commandModel);
-            _repository.SaveChanges();
 
             var commandReadDto = _mapper.Map<CommandReadDto>(commandModel);
 
-            return CreatedAtRoute(nameof(GetCommandById), new {Id = commandReadDto.Id}, commandReadDto);      
+            return CreatedAtRoute(nameof(GetCommandById), new { Id = commandReadDto.Id }, commandReadDto);
         }
 
         //PUT api/commands/{id}
         [HttpPut("{id}")]
         public ActionResult UpdateCommand(int id, CommandUpdateDto commandUpdateDto)
         {
             var commandModelFromRepo = _repository.GetCommandById(id);
-            if(commandModelFromRepo == null)
-            {
+            if (commandModelFromRepo == null)
                 return NotFound();
-            }
             _mapper.Map(commandUpdateDto, commandModelFromRepo);
 
             _repository.UpdateCommand(commandModelFromRepo);
-
-            _repository.SaveChanges();
-
             return NoContent();
         }
 
@@ -80,25 +72,18 @@ public ActionResult UpdateCommand(int id, CommandUpdateDto commandUpdateDto)
         public ActionResult PartialCommandUpdate(int id, JsonPatchDocument<CommandUpdateDto> patchDoc)
         {
             var commandModelFromRepo = _repository.GetCommandById(id);
-            if(commandModelFromRepo == null)
-            {
+            if (commandModelFromRepo == null)
                 return NotFound();
-            }
-
             var commandToPatch = _mapper.Map<CommandUpdateDto>(commandModelFromRepo);
             patchDoc.ApplyTo(commandToPatch, ModelState);
 
-            if(!TryValidateModel(commandToPatch))
-            {
+            if (!TryValidateModel(commandToPatch))
                 return ValidationProblem(ModelState);
-            }
 
             _mapper.Map(commandToPatch, commandModelFromRepo);
 
             _repository.UpdateCommand(commandModelFromRepo);
 
-            _repository.SaveChanges();
-
             return NoContent();
         }
 
@@ -107,15 +92,12 @@ public ActionResult PartialCommandUpdate(int id, JsonPatchDocument<CommandUpdate
         public ActionResult DeleteCommand(int id)
         {
             var commandModelFromRepo = _repository.GetCommandById(id);
-            if(commandModelFromRepo == null)
-            {
+            if (commandModelFromRepo == null)
                 return NotFound();
-            }
             _repository.DeleteCommand(commandModelFromRepo);
-            _repository.SaveChanges();
 
             return NoContent();
         }
-        
+
     }
 }

Data/SqlCommanderRepo.cs

@@ -22,6 +22,7 @@ public void CreateCommand(Command cmd)
             }
 
             _context.Commands.Add(cmd);
+            SaveChanges();
         }
 
         public void DeleteCommand(Command cmd)
@@ -31,6 +32,7 @@ public void DeleteCommand(Command cmd)
                 throw new ArgumentNullException(nameof(cmd));
             }
             _context.Commands.Remove(cmd);
+            SaveChanges();
         }
 
         public IEnumerable<Command> GetAllCommands()
@@ -50,7 +52,7 @@ public bool SaveChanges()
 
         public void UpdateCommand(Command cmd)
         {
-            //Nothing
+            SaveChanges();
         }
     }
 }

Dtos/CommandDto.cs

@@ -0,0 +1,40 @@
+using System.ComponentModel.DataAnnotations;
+
+namespace Commander.Dtos
+{
+    public class CommandCreateDto
+    {
+        [Required]
+        [MaxLength(250)]
+        public string HowTo { get; set; }
+
+        [Required]
+        public string Line { get; set; }
+
+        [Required]
+        public string Platform { get; set; }
+    }
+
+    public class CommandReadDto
+    {
+        public int Id { get; set; }
+
+        public string HowTo { get; set; }
+
+        public string Line { get; set; }
+
+    }
+
+    public class CommandUpdateDto
+    {
+        [Required]
+        [MaxLength(250)]
+        public string HowTo { get; set; }
+
+        [Required]
+        public string Line { get; set; }
+
+        [Required]
+        public string Platform { get; set; }
+    }
+}