FIX #59281: l10nve_sale #352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problema: -Al intentar registrar un pago de cliente, muestra un error. Solución: -Se refactoriza la función action_confirm para que pueda acceder correctamente a los valores de order, y recorra la respectiva lógica. Tarea (Link): https://binaural.odoo.com/web#id=59281&cids=2&menu_id=975&action=341&model=project.task&view_type=form Tarea de proyecto [x] Ticket de soporte []
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the action_confirm method where customer payment registration was failing. The fix reorganizes the validation logic by moving the product line validation and the not-allowed products validation inside the order iteration loop, ensuring proper access to order values.
Key Changes:
- Refactored
action_confirmmethod to correctly iterate over orders before performing validations - Updated module version from 1.0 to 1.2
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| l10n_ve_sale/models/sale_order.py | Restructured validation logic in action_confirm to access order context properly |
| l10n_ve_sale/manifest.py | Bumped version number to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacoBinaural
added
bug
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require a review from approvers teamThis rule is failing.This rule requires someone from the approver's team to approve the PR
|
JacoBinaural
added
✅ Validado
…_registrate_a_client_payment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problema:
-Al intentar registrar un pago de cliente, muestra un error.
Solución:
-Se refactoriza la función action_confirm para que pueda acceder correctamente a los valores de order, y recorra la respectiva lógica. Tarea (Link):
https://binaural.odoo.com/web#id=59281&cids=2&menu_id=975&action=341&model=project.task&view_type=form Tarea de proyecto [x]
Ticket de soporte []