L10n ve purchase#mig58220 binaural purchase #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrijiendo error al intentar instalar y al pasar facturas de proveedores Link:https://binaural.odoo.com/web#id=58454&cids=2&model=project.task&view_type=form
Se realiza ajustes para poder crear almacenes de consignacion y almacenes en general Link:https://binaural.odoo.com/web#id=58454&cids=2&model=project.task&view_type=form
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Venezuelan localization modules to version 1.1 and includes compatibility changes for newer Odoo framework versions. The changes primarily address deprecated methods and modernize XML view definitions.
Key changes:
- Version bumps from 1.0 to 1.1 across multiple l10n_ve modules
- Migration to newer Odoo framework patterns (chatter widget, privilege_id field)
- Deprecation handling for stock warehouse picking type creation
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| l10n_ve_stock_account/manifest.py | Version bump to 1.1 |
| l10n_ve_stock_account/views/stock_warehouse_views.xml | Removed readonly attribute from consignation warehouse field |
| l10n_ve_stock/manifest.py | Version bump to 1.1 |
| l10n_ve_stock/models/stock_warehouse.py | Replaced deprecated method implementation with super() call |
| l10n_ve_stock/views/stock_location_views.xml | Migrated from manual chatter div to chatter widget |
| l10n_ve_sale/manifest.py | Version bump to 1.1 |
| l10n_ve_pos/views/report_saledetails.xml | Updated xpath selectors and commented out unused xpath replacements |
| l10n_ve_pos/security/res_group.xml | Migrated from category_id to privilege_id field |
| l10n_ve_pos/data/res_group.xml | Migrated from category_id to privilege_id field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'company_id': self.company_id.id, | ||
| }, | ||
| }, max_sequence + 6 | ||
| #raise ("DeprecationWarning", "_get_picking_type_create_values is deprecated in Odoo 19.0, use _get_picking_type_create_values_and_sequence instead.") |
There was a problem hiding this comment.
Corrected spelling of 'recieve' to 'receive'.
Comment on lines
+13
to
+14
| #raise ("DeprecationWarning", "_get_picking_type_create_values is deprecated in Odoo 19.0, use _get_picking_type_create_values_and_sequence instead.") | ||
| #input_loc, output_loc = self._get_input_output_locations(self.reception_steps, self.delivery_steps) |
There was a problem hiding this comment.
Comentarios de código en lugar de código eliminado. Si este código está obsoleto y reemplazado por super(), debería eliminarse por completo en lugar de dejarlo comentado.
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require a review from approvers teamThis rule is failing.This rule requires someone from the approver's team to approve the PR
|
Ivan-Binaural
added
❌ Cambios funcionales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.