You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the last commit here, allOf validation is broken for most usecases. For example the allOf samples in the swagger docs don't validate, and in practice most uses of allOf will result in schemas which do not validate against any values.
Hrm. Never mind, allOf-validation is not as easily fixed as is done in this PR. The allOf of two oneOf schemas is not just what you get by concatenating them. An object property is only unaccounted for in an allOf-schema, if it is unaccounted for in all of its subschemas. The current implementation will complain if a property is unaccounted for in any of the subschemas. The PR's fix does something unrelated. Defaulting additionalProperties to true also feels janky.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cydparser
force-pushed
the
fix-validate-all-of
branch
from
An alternative fix would be to default
additionalPropertiestotrue.