Skip to content

verify hook#151

Open
mishaschwartz wants to merge 1 commit into
bird-house:masterfrom
mishaschwartz:verify-hooks
Open

verify hook#151
mishaschwartz wants to merge 1 commit into
bird-house:masterfrom
mishaschwartz:verify-hooks

Conversation

@mishaschwartz
Copy link
Copy Markdown

@mishaschwartz mishaschwartz commented May 22, 2026

Alternative to #150 as discussed in #150 (comment)

Must be implemented with Ouranosinc/Magpie#656

TODO:

  • add tests
  • update documentation
  • update changelog

Closes #150

Copy link
Copy Markdown
Member

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach. Seems cleaner. Just minor tweaks needed.

Comment thread twitcher/adapter/base.py
"""
Apply additional logic used to verify whether a request should be rejected.

.. versionadded:: 0.11.2
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider this a 0.12.0.

Comment thread twitcher/adapter/base.py
Comment on lines +84 to +85
Return False to indicate that the verify endpoint should return a "forbidden"
response regardless of whether the request is verified.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use False quotes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants