Fix persistent 'Invalid audio files' message in batch analysis#838
Open
tphakala wants to merge 1 commit intobirdnet-team:mainfrom
Open
Fix persistent 'Invalid audio files' message in batch analysis#838tphakala wants to merge 1 commit intobirdnet-team:mainfrom
tphakala wants to merge 1 commit intobirdnet-team:mainfrom
Conversation
The error message was not being cleared when selecting a new input or output directory. This fix ensures that the result_grid component is cleared whenever a new directory is selected, providing proper feedback to users. Fixes birdnet-team#809
Member
|
Tbh I can not reproduce the problem you are describing on current main. After trying the Testing steps I can say main behaves the same way as this PR does. Am I missing something? Also there might be a Gradio version mismatch, I forgot to update the version in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Invalid audio files" error message in the batch analysis tab was persisting even after selecting new input or output directories. Users reported that once this message appeared, it would remain visible indefinitely, even after restarting the application or processing valid files.
Solution
Modified the directory selection handlers to clear the
result_gridcomponent whenever a new directory is selected. This provides proper feedback to users by removing stale error messages when they change their input or output selections.Changes:
select_directory_on_empty()to return a grid clear operationselect_directory_wrapper()to return a grid clear operationresult_gridis defined to access the componentTesting
Tested by:
Fixes #809