Skip to content

Propagate errors correctly when decoding and parsing PSBTs - #363

Open
emma31-dev wants to merge 1 commit into
bitcoindevkit:masterfrom
emma31-dev:fix/357-psbt-decode-errors
Open

emma31-dev wants to merge 1 commit into
bitcoindevkit:masterfrom
emma31-dev:fix/357-psbt-decode-errors

Conversation

@emma31-dev

Copy link
Copy Markdown

Description

Fixes #357 by preserving typed Base64 and PSBT parsing errors in wallet sign instead of returning generic errors.

Notes to the reviewers

Uses the existing From conversions for DecodeError and PsbtError.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@emma31-dev
emma31-dev force-pushed the fix/357-psbt-decode-errors branch from d6c1825 to 1dd6f05 Compare October 20, 2026 22:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

wallet sign command returns generic error for decoding failures

1 participant