Repository navigation
Expose additional signing options in wallet sign - #365
Open
emma31-dev wants to merge 4 commits into
Open
emma31-dev wants to merge 4 commits into
emma31-dev wants to merge 4 commits into
Conversation
emma31-dev
marked this pull request as draft
October 21, 2026 17:30
emma31-dev
force-pushed
the
feat/358-sign-options
branch
from
October 21, 2026 17:51
643b19f to
40ead92
Compare
emma31-dev
marked this pull request as ready for review
October 21, 2026 17:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose the remaining signing controls in
wallet sign, including sighash handling, partial-signature removal, finalization, Taproot signing, and signature grinding. Closes #358 .Notes to the reviewers
tap_leaves_optionssupportsallandnone, as discussed in the issue. Unspecified options retain their defaults.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: