Expose validate_domain config in electrum constructor

[newtonick]

Description

I have an iOS wallet that uses Electrum and I would like to support self signed TLS certs. By exposing the validate_domain parameter this would allow the user to disabled all certificates verification.

I made this change locally and tested with my iOS wallet without any issues. Here is a screenshot of what I represent this validate_domain config to an end user in the app:

I don't believe adding this additional defaulted parameter would be a breaking change.

Notes to the reviewers

I believe this change is straight forward, but this is my first PR to BDK. Not sure if I'm missing anything that a contributor would be expected to provide. Not sure what kind of unit testing would be needed. Open to guidance.

Documentation

• bdk_wallet
• bitcoin
• uniffi
• Other:

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing
• I've added a changelog in the next release tracking issue (see example)
• I've linked the relevant upstream docs or specs above

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[reez]

ACK 25939a4

Left one small doc nit inline, but its not blocking from my side.

Thanks for the contribution. I’d also like to give other maintainers a bit of time to weigh in. My expectation is that this would most likely land with the next major release, given upstream already has 3.0 RC1/RC2 published, though we can revisit that if we end up needing another 2.x release.



BTW, I mentioned your app in our #showcase channel on Discord https://discord.com/channels/753336465005608961/1042437251851882556/1483569321945989211 nice job with the app

[ItoroD]

ACK 6bf0a51