Skip to content

test: add non-empty coverage for TxUpdate#2113

Closed
mubashirrao1122 wants to merge 1 commit intobitcoindevkit:masterfrom
mubashirrao1122:test/tx-update-non-empty
Closed

test: add non-empty coverage for TxUpdate#2113
mubashirrao1122 wants to merge 1 commit intobitcoindevkit:masterfrom
mubashirrao1122:test/tx-update-non-empty

Conversation

@mubashirrao1122
Copy link
Copy Markdown

This PR adds additional test coverage for TxUpdate::is_empty.

It verifies TxUpdate is reported as non-empty when:

  • txs is populated
  • seen_ats is populated
  • the update is extended with a non-empty update

Tests:

  • cargo test -p bdk_core --test test_tx_update

Copilot AI review requested due to automatic review settings February 4, 2026 16:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds targeted tests to ensure TxUpdate::is_empty reports false once key fields are populated or after merging in a non-empty update.

Changes:

  • Add a test asserting TxUpdate becomes non-empty when txs contains a transaction.
  • Add a test asserting TxUpdate becomes non-empty when seen_ats contains an entry.
  • Add a test asserting TxUpdate::extend makes the receiver non-empty when extending with a non-empty update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@evanlinjin
Copy link
Copy Markdown
Member

Closing for the same reasons presented in #2111 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants