fix(chain): add missing continue in CanonicalIter assumed-tx processing#2170
Merged
ValuedMammal merged 2 commits intobitcoindevkit:release/chain-0.23.xfrom Apr 16, 2026
Conversation
Collaborator
|
ACK 8daaad9 |
Contributor
Author
Right, but that seems unrelated to the change? |
ValuedMammal
approved these changes
Apr 16, 2026
ci: update pinned `rustls@0.23.38` ci: pin `libc` to 0.2.183 for 1.63.0 toolchain ci: pin `semver` to 1.0.27 for 1.63.0 toolchain ci: update pinned webpki-roots@1.0.7 ci: update pinned clap@4.6.1
…essing Without the `continue`, the loop falls through to the subsequent processing blocks when assumed-canonical transactions are the only remaining unprocessed source. If the anchored, seen, and leftover iterators are all exhausted, the loop reaches `return None` and silently drops the assumed transactions that were just marked canonical. Co-Authored-By: HAL 9000
ValuedMammal
force-pushed
the
2026-04-fix-canonical-iter-missing-continue
branch
from
8daaad9 to
27ab7ee
Compare
Collaborator
|
ACK 27ab7ee |
ValuedMammal
merged commit f07423a
into
bitcoindevkit:release/chain-0.23.x
19 checks passed
This was referenced Apr 16, 2026
Closed
Collaborator
|
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without the
continue, the loop falls through to the subsequent processing blocks when assumed-canonical transactions are the only remaining unprocessed source. If the anchored, seen, and leftover iterators are all exhausted, the loop reachesreturn Noneand silently drops the assumed transactions that were just marked canonical.Notes to the reviewers
Co-Authored-By: HAL 9000
Checklists
All Submissions:
Bugfixes: