fix(chain): prevent integer overflow in SpkIterator::new_with_range#2180
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Apr 23, 2026
Merged
Conversation
The start and end bound calculations used unchecked addition which overflows when given `u32::MAX`, causing the iterator to silently produce wrong results (e.g., an empty iterator for `0..=u32::MAX` in release mode). Use `saturating_add` to handle the boundary correctly. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
evanlinjin
force-pushed
the
2026-04-fix-spk-iterator-overflow
branch
from
b5786dd to
b340e96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The start and end bound calculations used unchecked addition which
overflows when given
u32::MAX, causing the iterator to silently producewrong results (e.g., an empty iterator for
0..=u32::MAXin releasemode). Use
saturating_addto handle the boundary correctly.Checklists
All Submissions:
Bugfixes: