fix: full_scan covers revealed range before applying stop_gap#2182
Open
noahjoeris wants to merge 2 commits intobitcoindevkit:masterfrom
Open
fix: full_scan covers revealed range before applying stop_gap#2182noahjoeris wants to merge 2 commits intobitcoindevkit:masterfrom
noahjoeris wants to merge 2 commits intobitcoindevkit:masterfrom
Conversation
noahjoeris
requested review from
evanlinjin,
luisschwab and
oleonardolima
as code owners
noahjoeris
commented
Apr 19, 2026
evanlinjin
requested changes
Apr 23, 2026
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
Thanks for this work. The approach is correct and minimal. Just some small things about docs and tests before ACK and merge.
noahjoeris
force-pushed
the
fix/full_scan
branch
from
281c3e6 to
187b007
Compare
Author
|
Thanks for the review! Addressed all comments. Docs updated, tests expanded and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2057.
full_scannow always covers the revealed range before applying the stop_gapNotes to the reviewers
Replaces #2181. That PR unified full_scan and sync into one path; per @evanlinjin's feedback we're keeping them separate and doing the minimal fix here instead
Changelog notice
Fixed: full_scan now always scans the full revealed range before applying stop_gap past last_revealed.
Checklists
All Submissions:
New Features:
Bugfixes: