Skip to content

Remove unused start-core.sh script#2190

Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
luisschwab:chore/remove-start-core-script
Apr 29, 2026
Merged

Remove unused start-core.sh script#2190
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
luisschwab:chore/remove-start-core-script

Conversation

@luisschwab
Copy link
Copy Markdown
Member

Changelog

- Remove the unused `ci/start-core.sh` script

@luisschwab luisschwab added this to the Chain 0.23.4 milestone Apr 25, 2026
@luisschwab luisschwab self-assigned this Apr 25, 2026
@luisschwab luisschwab requested a review from evanlinjin as a code owner April 25, 2026 15:45
@luisschwab luisschwab added the chore Non-coding related work label Apr 25, 2026
@oleonardolima oleonardolima moved this to Needs Review in BDK Chain Apr 27, 2026
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ae0e826

@oleonardolima
Copy link
Copy Markdown
Collaborator

Thanks! I'd appreciate if you could also remove it from release/chain-0.23.x.

@luisschwab
Copy link
Copy Markdown
Member Author

Thanks! I'd appreciate if you could also remove it from release/chain-0.23.x.

Sure, I can backport it.

@luisschwab
Copy link
Copy Markdown
Member Author

@oleonardolima done on #2192

Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ae0e826

@evanlinjin evanlinjin merged commit 0dbfdd2 into bitcoindevkit:master Apr 29, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in BDK Chain Apr 29, 2026
evanlinjin added a commit that referenced this pull request Apr 29, 2026
e9f78ef fix(ci): pin `rustls@0.23.39` to v0.23.26 (Luis Schwab)
add0ef0 chore: remove unused `start-core.sh` script (Luis Schwab)

Pull request description:

  Backports #2190 to `release/chain-0.23.x`

  ## Changelog
  ```
  - Remove the unused `ci/start-core.sh` script
  - Pin rustls@0.23.39 to v0.23.26 for MSRV
  ```

ACKs for top commit:
  evanlinjin:
    ACK e9f78ef

Tree-SHA512: abc907fc458307afe6bfea72d8b0b1f2f2c2806eccbdd4a2de4e1e9573b6c6c11f7c89379dd5e285396cee9c6f3b24a947a7f04b3cbe346bcb28c4d6eaf20a2c
@luisschwab luisschwab deleted the chore/remove-start-core-script branch April 29, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants