chore(tests): replace deprecated FeeRate::from_sat_per_vb_unchecked#455
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Apr 23, 2026
Merged
Conversation
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #455 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 24 24
Lines 5347 5348 +1
Branches 242 242
=======================================
+ Hits 4289 4290 +1
Misses 980 980
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
bitcoin-units 0.1.3deprecatedFeeRate::from_sat_per_vb_uncheckedin favor ofFeeRate::from_sat_per_vb_u32. Cargo resolves any 0.1.x automatically, so fresh CI runs started failing on master (and all open PRs) once 0.1.3 was published.This patch swaps every call site over to the new name. The two functions compute the same value for any input that fits in
u32; every existing call site passes a small literal (1, 3, 5, 10, 25, 50, 255, 454, 1000, 10_000), so no behavioural change.All usages are in test/fixture code (
src/wallet/coin_selection.rstest module,tests/wallet.rs,tests/build_fee_bump.rs) — no production code path was using the deprecated function.Notes to the reviewers
Utxo::txout()for Foreign variant #445, fix(wallet): retry coin selection on NoChange to avoid dust/zero drai… #448).Changelog notice
N/A — internal test-only change.
Checklists
All Submissions:
just pbefore pushing