Skip to content

chore(tests): replace deprecated FeeRate::from_sat_per_vb_unchecked#455

Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
none34829:chore/replace-deprecated-feerate-fn
Apr 23, 2026
Merged

chore(tests): replace deprecated FeeRate::from_sat_per_vb_unchecked#455
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
none34829:chore/replace-deprecated-feerate-fn

Conversation

@none34829
Copy link
Copy Markdown
Contributor

Description

bitcoin-units 0.1.3 deprecated FeeRate::from_sat_per_vb_unchecked in favor of FeeRate::from_sat_per_vb_u32. Cargo resolves any 0.1.x automatically, so fresh CI runs started failing on master (and all open PRs) once 0.1.3 was published.

This patch swaps every call site over to the new name. The two functions compute the same value for any input that fits in u32; every existing call site passes a small literal (1, 3, 5, 10, 25, 50, 255, 454, 1000, 10_000), so no behavioural change.

All usages are in test/fixture code (src/wallet/coin_selection.rs test module, tests/wallet.rs, tests/build_fee_bump.rs) — no production code path was using the deprecated function.

Notes to the reviewers

Changelog notice

N/A — internal test-only change.

Checklists

All Submissions:

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.21%. Comparing base (fbf803a) to head (be710a8).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   80.21%   80.21%           
=======================================
  Files          24       24           
  Lines        5347     5348    +1     
  Branches      242      242           
=======================================
+ Hits         4289     4290    +1     
  Misses        980      980           
  Partials       78       78           
Flag Coverage Δ
rust 80.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValuedMammal ValuedMammal added this to the Wallet 3.1.0 milestone Apr 23, 2026
Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK be710a8

@ValuedMammal ValuedMammal merged commit 35a87f3 into bitcoindevkit:master Apr 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants