feat: minimal sweep WIF QR-code implementation#53
Open
psychemist wants to merge 5 commits intobitcoindevkit:variant/2.0from
Open
feat: minimal sweep WIF QR-code implementation#53psychemist wants to merge 5 commits intobitcoindevkit:variant/2.0from
psychemist wants to merge 5 commits intobitcoindevkit:variant/2.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to sweep funds from an external WIF private key into the user's wallet by scanning a QR code or copy-pasting the raw WIF string.
What This Does
raw WIF,wif: prefix, andbitcoin:?wif= URIformatsFlow
Testing
Unit tests (JVM, no device needed)
./gradlew :app:testDebugUnitTestInstall on device/emulator
./gradlew installDebugManual: send testnet4 coins to the wpkh address derived from a test WIF then sweep. Check in-app logs for balance details per descriptor.
Check out test sweep transaction on testnet4 here:
Screenshots