Skip to content

Use bitcoin::Amount and bitcoin::FeeRate#198

Open
luisschwab wants to merge 2 commits intobitcoindevkit:masterfrom
luisschwab:refactor/feerate
Open

Use bitcoin::Amount and bitcoin::FeeRate#198
luisschwab wants to merge 2 commits intobitcoindevkit:masterfrom
luisschwab:refactor/feerate

Conversation

@luisschwab
Copy link
Copy Markdown
Member

Closes #192

Changelog

## Added
- Add `deserialize_fee_histogram`

## Breaking 
- Use `Amount` and `FeeRate` on `MempoolStats.fee_histogram`
- `submit_package` takes in `FeeRate` for `maxfeerate` instead of `f64`
- `submit_package` takes in `Amount` for `maxburnamount` instead of `f64`
- `get_fee_estimates` returns `FeeRate` instead of `f64`

## Changed
- Update `test_feerate_parsing` with an up to date fee histogram

@luisschwab luisschwab self-assigned this May 1, 2026
@luisschwab luisschwab requested a review from oleonardolima as a code owner May 1, 2026 16:02
@luisschwab luisschwab added the api A breaking API change label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use FeeRate for all fee fields

1 participant