Skip to content

Feature/ws2 new funding functions#543

Open
Daniel1984 wants to merge 10 commits intobitfinexcom:masterfrom
Daniel1984:feature/ws2_new_funding_functions
Open

Feature/ws2 new funding functions#543
Daniel1984 wants to merge 10 commits intobitfinexcom:masterfrom
Daniel1984:feature/ws2_new_funding_functions

Conversation

@Daniel1984
Copy link

Description:

adding new WSv2 functions

Breaking changes:

none

New features:

  • WSv2: submitFundingOffer function
  • WSv2: cancelFundingOffer function
  • WSv2: closeFundingLoan function
  • WSv2: closeFundingCredit function

Fixes:

none

PR status:

  • Version bumped
  • Change-log updated
  • Documentation updated

Copy link
Contributor

@JacobPlaster JacobPlaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good lgtm

@JacobPlaster JacobPlaster marked this pull request as ready for review June 9, 2020 13:49
@JacobPlaster
Copy link
Contributor

Would be nice to get a simple example usage file, similar to https://github.com/bitfinexcom/bitfinex-api-node/blob/master/examples/ws2/order_tif.js

@JacobPlaster JacobPlaster marked this pull request as draft June 9, 2020 13:51
@Daniel1984 Daniel1984 marked this pull request as ready for review June 17, 2020 11:38
@Daniel1984
Copy link
Author

@JacobPlaster, as per discussion, I added, what I think is the simplest usage examples for new functions. Throwing coming soon exception for functions that are missing socket input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants