Conversation
_isEmpty only works for collections, here you are evaluating an individual item so something like checking for undefined would be best. This fixes my bug reported: bitfinexcom#546
jcbit
commented
Jun 28, 2020
Author
jcbit
left a comment
jcbit
left a comment
There was a problem hiding this comment.
used lodash isUndefined which is similar to what is used in other parts of the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_isEmpty only works for collections, here you are evaluating an individual item so something like checking for undefined would be best. This fixes my bug reported:
#546
Description:
...
Breaking changes:
New features:
Fixes:
PR status: