Add missing new ClearButtonIcon parameter to BitTextField (#12219)#12220
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAdded customizable clear button icon support to the BitTextField component by introducing two new parameters: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds the missing external-icon API surface for BitTextField’s clear button, aligning it with other components that support BitIconInfo-based icon customization.
Changes:
- Added
ClearButtonIcon(BitIconInfo?) andClearButtonIconName(string?) parameters toBitTextField. - Updated
BitTextFieldrendering to useBitIconInfo.From(...)for the clear button icon (with"Cancel"fallback). - Updated the demo parameter list to document the new parameters.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/BlazorUI/Bit.BlazorUI/Components/Inputs/TextField/BitTextField.razor.cs | Introduces new clear-button icon parameters and docs. |
| src/BlazorUI/Bit.BlazorUI/Components/Inputs/TextField/BitTextField.razor | Switches clear-button icon rendering to BitIconInfo/*IconName pattern. |
| src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/TextField/BitTextFieldDemo.razor.cs | Documents the new parameters in the demo metadata. |
closes #12219
Summary by CodeRabbit