Sign web release manifests#1128
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Addressed the failing Quality + Smoke check. The failure was React Doctor reporting existing UI-source findings even though this PR only changes release-manifest scripts/workflows. The latest commit keeps React Doctor strict for pushes and UI-source PRs, and skips it only for pull requests that do not touch React UI source. Local verification after the workflow change: |
Summary
Verification
RELEASE_MANIFEST_PRIVATE_KEY_PEMforbitsocialnet/5chancorepack yarn installcorepack yarn buildcorepack yarn lint(passes with existing warnings)corepack yarn type-checkcorepack yarn knipbuild/and verified the ECDSA signature locally/Users/Tommaso/Desktop/bitsocial/bitsocial-web-5chan-app-version-statusNote
Medium Risk
Introduces a new cryptographic signing step in the release pipeline using a private key secret; misconfiguration could break releases or produce unverifiable manifests, but changes are isolated to build/release tooling.
Overview
Adds generation of a signed SHA-256 file manifest for the static web build:
yarn release:manifestnow walksbuild/, records per-file size/hash plus metadata, and produces5chan-release-manifest.jsonand an ECDSA P-256 signature payload.Updates the tag
releaseworkflow to run this signer during Linux x64 builds and include the manifest + signature files inside the HTML release zip, and adds a helper script to generate an EC keypair for provisioningRELEASE_MANIFEST_PRIVATE_KEY_PEM.Tweaks CI to skip
yarn doctoron pull requests unless React UI source files changed, and ignores local release signing PEMs plus generatedrelease-assets/in.gitignore.Reviewed by Cursor Bugbot for commit 85c9a9f. Bugbot is set up for automated code reviews on this repo. Configure here.