Skip to content

Conversation

@justindbaur
Copy link
Member

🎟️ Tracking

📔 Objective

Bump to use the .NET 10 SDK to build the projects in this repo. I'm currently not going to retarget any project to use .NET 10. I'll do that when there are things in .NET 10 I want to use in the projects.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.51%. Comparing base (375195b) to head (99b5992).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   48.51%   48.51%           
=======================================
  Files          36       36           
  Lines         907      907           
  Branches       73       73           
=======================================
  Hits          440      440           
  Misses        437      437           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2025

Logo
Checkmarx One – Scan Summary & Details46111ef3-e3af-4474-b610-fd54b6d5b84e

Great job! No new security vulnerabilities introduced in this pull request

@justindbaur justindbaur marked this pull request as ready for review December 19, 2025 13:31
@justindbaur justindbaur requested review from a team as code owners December 19, 2025 13:31
@claude
Copy link

claude bot commented Dec 19, 2025

Claude finished @justindbaur's task in 2m 11s —— View job


Code Review Complete

I've reviewed the PR that updates the .NET SDK version to 10. Here are my findings:

Summary

This PR updates global.json to require .NET 10.0.100 SDK and updates the CLAUDE.md documentation accordingly. The changes are minimal and focused on the SDK requirement only, not retargeting frameworks.

Assessment

The changes look good for an SDK-only update. The PR author explicitly states they're "not going to retarget any project to use .NET 10" yet, so keeping projects on net8.0 target framework while using the .NET 10 SDK is intentional.

Observations

  • global.json correctly updated from 8.0.100 to 10.0.100
  • ✅ CLAUDE.md documentation updated to reflect .NET 10 SDK requirement
  • ✅ Changes are minimal and focused as described in PR objective
  • ℹ️ All projects remain on net8.0 target framework (intentional per PR description)

Suggestions (Optional)

Consider documenting the SDK requirement in README.md for developers who don't read CLAUDE.md:

## Prerequisites

- .NET 10.0 SDK or later (check with `dotnet --version`)

This would help developers quickly identify build requirements. However, this is not blocking since CLAUDE.md already documents it.


@justindbaur justindbaur merged commit e7876f1 into main Dec 19, 2025
19 checks passed
@justindbaur justindbaur deleted the use-net10-sdk branch December 19, 2025 13:40
Copy link
Contributor

@theMickster theMickster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude's comment is nothing super-critical IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants