-
Notifications
You must be signed in to change notification settings - Fork 86
[PM-23409] feat: Add client certificate authentication (mTLS) support for self-hosted environments #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
|
Any updates on this implementation? |
Just waiting on any comments |
|
Hey @jalenfran, thanks a lot for your PR! Please excuse the long silence, an automation issue unfortunately kept this ticket off our review board. We do want to support mTLS and will be reviewing the PR shortly. |
|
@maxkpower do you have any Updates on this. I would love to fully entroll Bitwarden but without mTLS it is to insecure. Is there and ETA or new Status? Probably soon to be in the IOS Beta? |
|
Adding a bump here. Would love to see this functionality landed |
@maxkpower May I ask if there are any updates on the implementation of this feature? |
|
@maxkpower Is there any updates on this feature? Really looking forward to use this feature |
|
I fixed the merge conflicts. |
|
@maxkpower Ready to release now?) |
|
@maxkpower do you have any Updates on this. |
|
@matt-livefront any Updates on this? You are the one assigned as reviewer. |
|
It’s been several weeks now and this PR is still waiting without any visible progress. The implementation seems to be complete, tested, and the community is clearly interested. Could we please get an update on what exactly is blocking this from moving forward? |
I don’t want to be pessimistic, but at the moment it seems something is going wrong with Bitwarden’s development. For weeks we’ve suddenly had so many issues with the browser extensions. It’s confusing how such buggy versions could be released to the public. They also don’t do any rollback. instead they leave the broken extensions in place, trying to fix the issues while customers have to wait and continue using buggy versions for so long. Sorry for this post, but this is my subjective feeling at the moment. Something just isn’t right… I hope everything will get back on track again soon :( |
🎟️ Tracking
📔 Objective
This PR implements client certificate authentication (mTLS) support for iOS app when connecting to self-hosted Bitwarden environments that require client certificates.
Key Features:
Technical Implementation:
ClientCertificateConfigurationmodel for certificate data and metadataClientCertificateServicefor secure certificate management operationsCertificateHTTPClientwith URLSession delegate for mTLS authenticationThis enables users to authenticate with self-hosted Bitwarden servers that require client certificates for enhanced security.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
Key Areas for Review:
Files to Focus On:
ClientCertificateService.swift- Core certificate management logicCertificateHTTPClient.swift- mTLS HTTP client implementationSelfHostedView.swift- UI integration and user experienceStateService.swift&AppSettingsStore.swift- Secure storage implementation:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes