fix(binary-scan): warn instead of fail when no files match configured patterns#1735
Open
bd-spratikbharti wants to merge 1 commit intomasterfrom
Open
fix(binary-scan): warn instead of fail when no files match configured patterns#1735bd-spratikbharti wants to merge 1 commit intomasterfrom
bd-spratikbharti wants to merge 1 commit intomasterfrom
Conversation
dterrybd
approved these changes
Apr 23, 2026
Contributor
dterrybd
left a comment
dterrybd
left a comment
There was a problem hiding this comment.
Looks great to me. Adding Chris to review the message changes.
cpottsbd
reviewed
Apr 23, 2026
| multiTargets.forEach(operationRunner::updateBinaryUserTargets); | ||
| } else { | ||
| operationRunner.publishBinaryFailure("Binary scanner did not find any files matching any pattern."); | ||
| String message = "Binary scanner did not find any files matching the configured patterns."; |
Contributor
There was a problem hiding this comment.
Nittiest of nits: I believe we have generally capitalized "Scanner" when referring to the tool. (Which was not done in the original line 71 but was in line 78 so we've perhaps not been consistent.)
Collaborator
Author
There was a problem hiding this comment.
Thanks for pointing that out — happy to fix capitalization in a follow‑up if you’d like.
cpottsbd
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Context
Projects in CI/CD pipelines often have binary scan patterns (e.g. *.jar) configured globally, but not every project produces matching binaries. Previously, this
caused FAILURE_BLACKDUCK_FEATURE_ERROR (exit code 11), failing the pipeline unnecessarily.
Other binary scan paths (no patterns configured, autonomous mode) already handled "no binaries found" gracefully. This change makes the pattern-matching path
consistent with that behavior.
What's NOT changed