Repository navigation
CLA: fail closed when commits can't be read or a commit has no login - #20
Merged
Merged
Conversation
The commits are read into a variable and their count must match the pull request's, so a failed or short read stops the step instead of leaving a member's pull request all exempt. A commit whose author has no GitHub login now stops the step for a maintainer: the action would credit it to its committer. A commit count that isn't a positive number also stops it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers the two change requests on #19 (round 1 at d41dd9b).
cla-reusable.yml's exemption step now stops for a maintainer instead of passing when:< <(...)was invisible toset -e, so a member's pull request came out all exempt);if, a failed[is just false).The README row for
cla-reusable.ymllists the new failure cases. Version stays 1.3.0 (not released).Validation
Locally, at 9df238f:
tests/test_cla_check.pyadds 13 cases: a commit with no login (member and outside opener,[null],[null, m1],[m1, null],[ext, null]), a failed commits read, a short read, an empty read, and a commit count ofnullor0. Against d41dd9b's workflow all 13 fail and the other 13 pass.The round-1
verify-19.sh, cloning this commit instead of GitHub: d41dd9b gives 10 PASS, 2 FAIL (V06, V12); 9df238f gives V06 and V12 PASS. V11 reads CI on GitHub, so it is confirmed after push.