Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,14 @@ on:
default: false
secrets:
DOCKER_USERNAME:
description: Never passed by a caller. The release environment's secret of this name.
description: >-
Map it by name from the caller. The value comes from the release environment, which the
caller's job can't read; without the mapping the environment job sees it empty.
required: false
DOCKER_TOKEN:
description: Never passed by a caller. The release environment's secret of this name.
description: >-
Map it by name from the caller. The value comes from the release environment, which the
caller's job can't read; without the mapping the environment job sees it empty.
required: false
outputs:
images:
Expand Down
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ jobs:
Use the SHA of a `v*` tag of this repository, never a branch. Tags here are created only by the release
App and can't be moved or deleted, so a version comment always matches its SHA.

`release-check.yml` and `publish.yml` read the release App key in jobs that run in the caller's `release`
environment. A reusable workflow gets an environment secret only when the caller passes it, so map it by
name as above, alongside any other secrets such as `registry-token`. The caller's own job can't read the
`release-check.yml` and `publish.yml` read the release App key, and `docker.yml` reads `DOCKER_USERNAME` and
`DOCKER_TOKEN`, in jobs that run in the caller's `release` environment. A reusable workflow gets an
environment secret only when the caller passes it, so map each by name as above, alongside any other secrets
such as `registry-token`. The caller's own job can't read the
value; GitHub supplies it inside the environment.

Call `dev-security.yml` from a workflow that runs on `pull_request`, with a job named `dev-security`, so the
Expand Down
Loading