Serve HTTP status codes from a local server in network tests#2191
Open
XhmikosR wants to merge 1 commit into
Open
Serve HTTP status codes from a local server in network tests#2191XhmikosR wants to merge 1 commit into
XhmikosR wants to merge 1 commit into
Conversation
|
coverage: 76.203% (+0.009%) from 76.194% — XhmikosR:xmr/test-http into bleachbit:master |
XhmikosR
marked this pull request as ready for review
July 12, 2026 11:59
Member
Contributor
Author
|
IMHO this is much preferable and cleaner. Only con we don't test https right now. |
Contributor
Author
|
I personally keep hitting these errors, for example https://github.com/XhmikosR/bleachbit/actions/runs/29275856857/job/86904597631 |
Contributor
Author
|
I still think we should merge this. It doesn't make any sense for us to rely on external services and have CI failures for that reason, when we can achieve the same in a proper, robust way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully fix the random network test failures since we won't be hitting real sites. Not sure if it's the best solution, but IMHO it's crucial that CI is stable.