Add comprehensive test coverage analysis and improvement proposals#749
Merged
dangershony merged 3 commits intomainfrom Apr 14, 2026
Merged
Add comprehensive test coverage analysis and improvement proposals#749dangershony merged 3 commits intomainfrom
dangershony merged 3 commits intomainfrom
Conversation
Analyze all 4 test projects (~294 tests) and identify coverage gaps: - Improvements to 7 existing E2E integration tests (DB assertions, balance deltas, cross-profile validation) - 10 new E2E test proposals (wallet import/delete, many investors, DB integrity, subscribe type, etc.) - 8 new SDK-level test classes (LiteDB round-trips, WalletFactory, DatabaseManagementService, PortfolioService) - 15+ edge cases cataloged with risk assessment - SDK call parity analysis: 7/9 gaps resolved, 2 remaining (Lightning, tx preview), only 1/7 has test coverage - 3 bugs documented (orphaned DerivedProjectKeys on delete, dead LiteDbDocumentMapping code, no duplicate wallet guard)
Contributor
|
Can I pick up bugs found in test_edge_cases.md ? |
Member
Author
You can do the key deletion form database |
dangershony
added a commit
that referenced
this pull request
Apr 4, 2026
Implement two new E2E integration tests based on PR #749 test coverage analysis: - WalletImportAndProjectScanTest: validates seed import UI flow, wallet identity determinism (same seed = same WalletId), balance preservation, and ScanFounderProjects discovery after device loss recovery. - InvestmentCancellationTest: validates above-threshold pending investment cancellation, fund release back to investor, and successful re-investment after cancel (CancelInvestmentRequest had zero E2E coverage). Both tests follow the multi-profile WithProfileWindow pattern and include companion markdown documentation.
dangershony
added a commit
that referenced
this pull request
Apr 13, 2026
#753) * Add wallet import + project scan and investment cancellation E2E tests Implement two new E2E integration tests based on PR #749 test coverage analysis: - WalletImportAndProjectScanTest: validates seed import UI flow, wallet identity determinism (same seed = same WalletId), balance preservation, and ScanFounderProjects discovery after device loss recovery. - InvestmentCancellationTest: validates above-threshold pending investment cancellation, fund release back to investor, and successful re-investment after cancel (CancelInvestmentRequest had zero E2E coverage). Both tests follow the multi-profile WithProfileWindow pattern and include companion markdown documentation. * Fix InvestmentCancellationTest to reload investments from SDK before cancel AddToPortfolio does an optimistic local insert without WalletId or TransactionId. CancelInvestmentAsync requires both fields. The test now polls LoadInvestmentsFromSdkAsync to wait for the indexer to populate those fields before attempting cancellation. * Expand cancellation test to 3-step flow: cancel before approval, cancel after approval, and confirm
Re-analyze all 6 documents after ~180 new tests were added: - Test count grew from ~294 to ~475+ (SDK tests nearly tripled) - Mark 2/10 E2E proposals as implemented (wallet import, cancellation) - Mark 1/8 SDK proposals as implemented (ScanFounderProjects) - Update SDK parity: all 9 gaps now resolved (was 7/9), Lightning fully implemented - Re-confirm all 3 bugs still exist (orphaned DB data, dead code, no duplicate guard) - Revise priority rankings to emphasize bug fixes and LiteDB round-trip tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full analysis of the test suite across all 4 test projects (~294 tests), identifying coverage gaps and proposing concrete improvements.
Documents Added
TEST_COVERAGE_ANALYSIS.mdTEST_IMPROVEMENTS.mdTEST_NEW_PROPOSALS.mdTEST_SDK_PROPOSALS.mdTEST_EDGE_CASES.mdTEST_SDK_PARITY_ANALYSIS.mdKey Findings
DerivedProjectKeyson wallet delete, deadLiteDbDocumentMappingcode, no duplicate wallet guardEstimateFeeAndSizecalls)Priority Recommendations