test(desktop): survive early menu dismissals in the agent-voice spec - #6530
Open
Maxwellimus wants to merge 1 commit into
Open
test(desktop): survive early menu dismissals in the agent-voice spec#6530Maxwellimus wants to merge 1 commit into
Maxwellimus wants to merge 1 commit into
Conversation
Shortly after a cold load, background huddle-state settling re-renders the participant tiles and dismisses a just-opened Radix popover. In a fresh worker a single click then fails deterministically — and every CI retry runs in a fresh worker, so a first-attempt failure of this spec could never recover. Retry the open-and-read unit (open, title, toggle) until the menu holds through it. The underlying dismissal is a product bug worth its own look: an open agent-voice menu can be closed by background state settling the user never initiated. Signed-off-by: Max Lampert <maxwell@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
huddle-transcription.spec.ts› assigns distinct agent voices… fails deterministically when run in a fresh worker (--repeat-eachsolo runs: 0/6 pass on pristine main): shortly after a cold load, background huddle-state settling re-renders the participant tiles and dismisses the just-opened Radix voice menu. Every CI retry runs in a fresh worker, so a first-attempt failure can never recover — this spec has been failing whole Smoke shards across unrelated PRs (e.g. #6455 twice today).Fix: retry the open-and-read unit (open menu → title visible → TTS toggle checked) with
expect().toPass()until the menu holds through it. After hardening: 10/10 sequential solo runs pass (0/6 before), full file 26/26.Product bug worth a follow-up look (out of scope here): an open agent-voice popover can be dismissed by background state settling the user never initiated — trace shows the menu opening and closing with no user interaction. Repro: open the voice menu immediately after the huddle window cold-loads.