Skip to content

fix(desktop): align jump-to-latest pill with composer height - #6606

Draft
tellaho wants to merge 1 commit into
mainfrom
tho/jump-to-latest-height
Draft

fix(desktop): align jump-to-latest pill with composer height#6606
tellaho wants to merge 1 commit into
mainfrom
tho/jump-to-latest-height

Conversation

@tellaho

@tellaho tellaho commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Category: fix
User Impact: Jump to Latest now stays above the composer as a draft grows to multiple lines.

Problem: On WebKit, the pill's transform could retain a stale inherited composer-height value after the composer expanded, leaving the control stranded inside the composer.

Solution: Position and animate the pill with its absolute bottom offset, which consumes the live composer height through layout rather than a promoted transform layer. A smoke test now verifies that the pill rises by the full composer growth and remains clear of the composer.

File changes

desktop/src/features/messages/ui/MessageTimeline.tsx
Anchor Jump to Latest with a live bottom offset instead of a translated compositor layer so composer resizing reliably moves it.

desktop/tests/e2e/smoke.spec.ts
Add coverage that expands a detached timeline's composer and checks the pill tracks the full height increase without overlapping it.

Reproduction steps

  1. Open a channel with enough messages to scroll.
  2. Scroll away from the newest message until Jump to Latest appears.
  3. Add several lines to the composer without sending.
  4. Confirm Jump to Latest rises with the composer and remains directly above it.

Validation

  • pnpm --dir desktop test — 5,397 passed
  • pnpm --dir desktop check — passed with four existing informational warnings outside this diff
  • pnpm --dir desktop typecheck — passed
  • pnpm --dir desktop exec playwright test tests/e2e/smoke.spec.ts --project=smoke — 26 passed
  • Push hooks — desktop check, typecheck, and tests passed

Screenshots / Demos

Both captures use the same long, mid-history timeline and the same four-line composer.

Before After
The stale pill position overflows into the expanded composer. The pill tracks the live composer height and stays clear above it.
Before — Jump to Latest overlaps the tall composer After — Jump to Latest clears the tall composer

Co-authored-by: Rizz <302abe414ca6e3134763d2539bfcf145aea2a63fe5f8455204ed602fd40cf381@buzz.block.builderlab.xyz>
Signed-off-by: Rizz <302abe414ca6e3134763d2539bfcf145aea2a63fe5f8455204ed602fd40cf381@buzz.block.builderlab.xyz>
@tellaho
tellaho requested a review from a team as a code owner August 23, 2026 04:01
@tellaho
tellaho marked this pull request as draft August 23, 2026 07:11
@tellaho tellaho changed the title fix desktop jump pill position as composer grows fix(desktop): keep jump pill above growing composer Aug 23, 2026
@tellaho tellaho changed the title fix(desktop): keep jump pill above growing composer fix(desktop): align jump-to-latest pill with composer height Aug 23, 2026
tellaho pushed a commit that referenced this pull request Aug 23, 2026
tellaho pushed a commit that referenced this pull request Aug 23, 2026
tellaho pushed a commit that referenced this pull request Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant