Skip to content

chore(buysell): refactor update security code #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
+5 −26
Open

chore(buysell): refactor update security code #6316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/blockchain-wallet-v4-frontend/src/modals/BuySell/UpdateSecurityCode/index.ts
View file
Open in desktop

This file was deleted.

15 changes: 4 additions & 11 deletions ...UpdateSecurityCode/UpdateSecurityCode.tsx → ...dals/BuySell/UpdateSecurityCode/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,8 @@ import { useRemote } from 'hooks'
import { isNabuError } from 'services/errors'

import Loading from '../template.loading'
import { UpdateSecurityCodeComponent } from './types'

const UpdateSecurityCode: UpdateSecurityCodeComponent = ({ backToEnterAmount }) => {
const UpdateSecurityCode = ({ backToEnterAmount }: { backToEnterAmount: () => void }) => {
const dispatch = useDispatch()
const [cvv, setCvv] = useState<string | null>(null)
const { data: order } = useRemote(selectors.components.buySell.getBSOrder)
Expand All @@ -52,10 +51,6 @@ const UpdateSecurityCode: UpdateSecurityCodeComponent = ({ backToEnterAmount })
}
}

const errorCallback = () => {
backToEnterAmount()
}

useEffect(() => {
return () => {
dispatch(actions.components.buySell.cvvStatusReset())
Expand All @@ -64,14 +59,14 @@ const UpdateSecurityCode: UpdateSecurityCodeComponent = ({ backToEnterAmount })

if (error) {
if (isNabuError(error)) {
return <GenericNabuErrorFlyout error={error} onDismiss={errorCallback} />
return <GenericNabuErrorFlyout error={error} onDismiss={backToEnterAmount} />
}

return (
<FlyoutOopsError
action='retry'
data-e2e='sbUpdateSecurityCodeSectionAgain'
handler={errorCallback}
handler={backToEnterAmount}
/>
)
}
Expand Down Expand Up @@ -146,9 +141,7 @@ const UpdateSecurityCode: UpdateSecurityCodeComponent = ({ backToEnterAmount })
<FormattedMessage
id='modals.simplebuy.card_ending_in'
defaultMessage='Card Ending in {lastFour}'
values={{
lastFour: method.card?.number
}}
values={{ lastFour: method.card?.number }}
/>
}
/>
Expand Down
8 changes: 0 additions & 8 deletions packages/blockchain-wallet-v4-frontend/src/modals/BuySell/UpdateSecurityCode/types.ts
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions packages/blockchain-wallet-v4-frontend/src/modals/BuySell/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,7 @@ class BuySell extends PureComponent<Props, State> {
)}
{this.props.step === 'UPDATE_SECURITY_CODE' && (
<FlyoutChild>
<UpdateSecurityCode
backToEnterAmount={this.backToEnterAmount}
handleClose={this.handleClose}
/>
<UpdateSecurityCode backToEnterAmount={this.backToEnterAmount} />
</FlyoutChild>
)}
{this.props.step === 'CRYPTO_SELECTION' && (
Expand Down