⚡ Add better indexes for searching ozone events by comment keyword and batch id #4261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Oct 7, 2025
Comment on lines
+15
to
+16
| // Add the trgm extension first | ||
| await sql`CREATE EXTENSION IF NOT EXISTS pg_trgm`.execute(db) |
Collaborator
There was a problem hiding this comment.
Just a note that I think this may require superuser access on the database. So would have to check how it will play with the ozone distro and other deployments.
devinivy
reviewed
Oct 7, 2025
Comment on lines
4
to
13
| // Remove the old index for batch id that's not very optimized | ||
| await sql`DROP INDEX IF EXISTS "moderation_event_mod_tool_batch_id_idx"`.execute( | ||
| db, | ||
| ) | ||
| // create the new optimized index for batch id | ||
| await sql` | ||
| CREATE INDEX "moderation_event_batch_created_id_desc_idx" | ||
| ON "moderation_event" ( ("modTool"->'meta'->>'batchId'), "createdAt" DESC, "id" DESC ) | ||
| WHERE ("modTool"->'meta'->>'batchId') IS NOT NULL | ||
| `.execute(db) |
Collaborator
There was a problem hiding this comment.
Probably no big deal, but this will create a period where there's no index coverage at all. If that's an issue it could be addressed by creating the new index before dropping the old one.
devinivy
reviewed
Oct 7, 2025
| `.execute(db) | ||
|
|
||
| await sql`DROP INDEX IF EXISTS "moderation_event_comment_trigram"`.execute(db) | ||
| await sql`DROP IF EXISTS pg_trgm CASCADE`.execute(db) |
Collaborator
There was a problem hiding this comment.
Suggested change
| await sql`DROP IF EXISTS pg_trgm CASCADE`.execute(db) | |
| await sql`DROP EXTENSION IF EXISTS pg_trgm CASCADE`.execute(db) |
devinivy
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.