bsky: improve error messaging for DPoP bound access tokens #4333
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
commented
Nov 9, 2025
| // Proof-of-Possession (PoP) tokens are not allowed here | ||
| // https://www.rfc-editor.org/rfc/rfc7800.html | ||
| throw new AuthRequiredError( | ||
| 'Malformed token: DPoP not supported', |
Contributor
Author
There was a problem hiding this comment.
In the PDS we just give Malformed token, but here I think it's probably wise to be explicit and say "DPoP isn't supported", since getting here in the first place would be already a developer error (using Bearer <token> with a DPoP bound access token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the changeset for the details, I discovered whilst helping someone in the AT Protocol Touchers discord that the bsky.social server will accept DPoP bound access tokens sent as
Bearer <dpop-access-token>instead ofDPoP <dpop-access-token>(a fairly easy developer mistake), but the server misdirects the developer with the error "Bad token scope", because thescopeon a DPoP bound access token is the actual oauth scopes likeatproto transition:generic, when the bsky.social server expectscom.atproto.accessor similar.This change just makes that error a little bit more visible to a developer. cc @matthieusieben