Makefile to Bazel targets - #218
Conversation
e273f98 to
ccaf517
Compare
4a94152 to
ccaf517
Compare
a91e70c to
ccaf517
Compare
158b4ed to
41638ac
Compare
…ndows ci job errors
41638ac to
04c51c6
Compare
phiwuu
left a comment
phiwuu
left a comment
There was a problem hiding this comment.
Also please update the section on make test in file documentation/dev_setup.md
6638ada to
ead1c8c
Compare
ead1c8c to
3cb4884
Compare
mugdhadhole1
added
the
internal
There was a problem hiding this comment.
In this file
unit and system test targets are replaced with bazel targets
This is going to affect the coverage
coverage run -p --rcfile=coverage.cfg --branch --data-file .coverage \
This command is going to expect the .coverage/.coverage.* files and bazel test doesn't write to these files.
This will most certainly give an incorrect coverage
There was a problem hiding this comment.
Do remove the make commands if they are replaced with the bazel targets
| - name: Check output files | ||
| if: always() | ||
| run: | | ||
| util/check_local_modifications.sh |
There was a problem hiding this comment.
Why was this line removed?
There was a problem hiding this comment.
The CI shows only 3 tests.
Executed 3 out of 3 tests: 3 tests pass.
Some unit test files are missing the main entry point
if __name__ == "__main__":
unittest.main()
898fa02 to
40c9c04
Compare
3 participants
i. Unit-tests
ii. system-tests
iii. test-large-partial