Fix Sao Paulo bug in zoneinfo_rs #663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes here address two bugs. The first was involved incorrect comparison of transitions when the previous transition was a non named rule and had a numeric format. The second bug fix addresses incorrectly calculating the upper bound of the final year that transitions need to be calculated until.
Manishearth
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #662.
This PR fixes a bug in
zoneinfo_rsthat was causing a failures on Sao Paulo time zone tests.Primary bug fixes are in feb61e1.
The other three commits are adding related to adding tests or rebuilding the compiled data.