Santiago Jiménez solution - #10
Open
Naryalin wants to merge 13 commits into
Hidden character warning
The head ref may contain hidden characters: "SantiagoJim\u00e9nez-Solution"
Open
Conversation
Fix node js version error from Open SSL
Add .eslintrc.js for Vue lint compatibility, fix line ending error in ESLint rules, add missing bracket in routes/index.js. Rename view files for multi-word consistency and update routes accordingly.
Wrap NavButton as component, adjust alignment of nav inside app-bar
Now store uses the service getAllData to fetch and manage the state of users.
Now size and type of data are customizable
Add flag "--legacy-peer-deps" to npm install because of conflicts between eslint-plugin-prettier and vue/eslint-config-prettier. Keep this note until find a configuration where "npm install" and "npm serve" works as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Interview Solution
Description
This pull request includes my solution for the technical interview. Key features implemented:
Router Setup:
index.jsin therouterfolder./datawhich routes toDataTable.vue.Navigation Bar:
App.vuewith router integration.NavButton.vuefor easy addition of new routes in the navbar.Data Table with Search:
getAllDataservice to fetch data.DataTable.vueorganizes the data in a table with dynamic headers.PWA and Service Worker:
Additional Notes
npm i. For resolving these issues, please refer to the instructions provided in the README. Despite these conflicts, the application runs without any problems.