Added .cpp files in the algo subfolder to the add_library command in CMakeLists.txt for Fiber#16
Open
jjhegedus wants to merge 1 commit intoboost-cmake:masterfrom
Open
Added .cpp files in the algo subfolder to the add_library command in CMakeLists.txt for Fiber#16jjhegedus wants to merge 1 commit intoboost-cmake:masterfrom
jjhegedus wants to merge 1 commit intoboost-cmake:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After building Fiber successfully, I attempted to use it from my project and linking failed with the cryptic error, "undefined reference to vtable" in the constructor for the round_robin class.
A little searching on google led me to this issue on Stack Overflow... https://stackoverflow.com/questions/3065154/undefined-reference-to-vtable.
After reviewing the CMakeLists.txt file and the structure of the src folder, I found that the .cpp files in the algo subfolder of src were not included in the add_library command in the CMakeLists.txt file.
I made a very small change to add them to the add_library command in the CMakeLists.txt file. I tested the change on Windows 10, cross compiling to the Magic Leap (an Android variant) and the error was resolved. This has had minimal testing but it looks pretty clear that the missing files were the issue and the fix was very simple.