Update fptraits.hpp for gcc/windows/aarch64. #1350
Conversation
Also adds better error checking. Fixes #1348
| // PowerPC extended double precision format (128 bits) | ||
|
|
||
| static_assert(LDBL_MANT_DIG == 113, "Oops, assumption that long double is a 128-bit quantity is incorrect!!"); | ||
|
|
There was a problem hiding this comment.
In the PowerPC case should we check both 106 and 113 for LDBL_MANT_DIG? I assume the original code is old enough that 106 was the only option at the time.
There was a problem hiding this comment.
Not in the same branch, everything has to go to the correct #if branch otherwise we don't get the correct bits.
|
@mborland I can't seem to get CUDA/SYCL correct: am I correct in thinking that long double is 64 bit on the device and 80-bit on the host? If so is there a good way to configure that? |
That is correct.
I think we'd need to have one set of functions marked host and one set marked device and then let the compiler pick the right one. I'm out of town for the long weekend (MLK day), but I can add those on Tuesday if you'd like. |
Hmm, I suspect that since the functions aren't dependent on any template parameter, the static_assert will be triggered irrespective of whether the function is called or not. |
Also adds better error checking.
Fixes #1348