fix(cli): print full ids in builds list and deploy-tokens list (0.5.19) - #471
Open
TennyZhuang wants to merge 1 commit into
Open
fix(cli): print full ids in builds list and deploy-tokens list (0.5.19)#471TennyZhuang wants to merge 1 commit into
builds list and deploy-tokens list (0.5.19)#471TennyZhuang wants to merge 1 commit into
Conversation
….5.19) Same class as #468: these lists truncated ids to 8 chars (`id.slice(0, 8)`), so a copied build/token id could not be fed back to any command. Print the full id. (feedback.js's slice(0,8) is an after-the-fact receipt, not a copy source — intentionally left alone.) Server-side note: the #468 shape gate only guards :appId; a truncated buildId/tokenId still yields the old misleading failure. A matching shape gate for those params is a possible follow-up, tracked separately. Signed-off-by: Rhea Rafferty <rhea@hands.build> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Same class as #468:
builds listanddeploy-tokens listtruncated their id column to 8 chars (id.slice(0, 8)), so a copied build/token id could not be fed back to any command. (Raised by CC-Quiver-Owner: a feedback item should fix the class, not just the one case.)Changes
builds list: print the full build id.deploy-tokens list: print the full token id.feedback.js'sslice(0,8)is an after-the-fact receipt ("Updated ticket xxx."), not a copy source — intentionally left alone.Follow-up
The #468 server-side shape gate only guards
:appId; a truncatedbuildId/tokenIdstill yields the old misleading role/not-found failure. A matching shape gate for those params is a possible follow-up, not included here.Testing
CLI
tscclean. On merge, tagcli-v0.5.19triggers publish-cli.🤖 Generated with Claude Code